FreeCalypso > hg > freecalypso-tools
view libpwon/forkoff.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | ab54957dbe35 |
children |
line wrap: on
line source
#include <sys/types.h> #include <signal.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> extern char bootctrl_pwon_cmd[]; extern int bootctrl_duart28c_mode, bootctrl_etmoff_mode; static char shell_pathname[] = "/bin/sh"; void fork_exec_pwon_cmd() { int i; i = vfork(); if (i < 0) { perror("vfork"); exit(1); } if (i) return; execl(shell_pathname, "sh", "-c", bootctrl_pwon_cmd, (char *) 0); perror(shell_pathname); _exit(1); } pwon_if_needed() { if (bootctrl_duart28c_mode) { signal(SIGCHLD, SIG_IGN); fork_duart28c_pulse(); return(1); } if (bootctrl_pwon_cmd[0]) { signal(SIGCHLD, SIG_IGN); fork_exec_pwon_cmd(); return(1); } if (bootctrl_etmoff_mode) { bootctrl_do_etmoff(); return(2); } return(0); }