view librftab/rdcommon.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents a0f79bba0ad8
children
line wrap: on
line source

/*
 * This C file is not a compilation unit in itself, but is the common piece
 * (a set of static variables and functions) included in the librftab modules
 * responsible for reading different kinds of ASCII tables.
 */

#define	MAX_FIELDS_PER_LINE	64

static char *filename;
static FILE *rdfile;
static unsigned lineno;
static char linebuf[256], *line_fields[MAX_FIELDS_PER_LINE];
static unsigned line_nfields, line_field_ptr;

static int
read_line()
{
	char *cp;

	if (!fgets(linebuf, sizeof linebuf, rdfile))
		return(0);
	lineno++;
	cp = linebuf;
	for (line_nfields = 0; ; ) {
		while (isspace(*cp))
			cp++;
		if (*cp == '\0' || *cp == '#')
			break;
		if (line_nfields >= MAX_FIELDS_PER_LINE) {
			printf("%s line %d: too many fields on one line\n",
				filename, lineno);
			return(-1);
		}
		line_fields[line_nfields++] = cp;
		while (*cp && !isspace(*cp))
			cp++;
		if (*cp)
			*cp++ = '\0';
	}
	return(1);
}

static
get_field(retp)
	char **retp;
{
	int rc;

	if (line_field_ptr < line_nfields) {
		*retp = line_fields[line_field_ptr++];
		return(1);
	}
	do {
		rc = read_line();
		if (rc <= 0)
			return(rc);
	} while (!line_nfields);
	*retp = line_fields[0];
	line_field_ptr = 1;
	return(1);
}