FreeCalypso > hg > freecalypso-tools
view librftab/smallconv.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | b73c21a2148f |
children |
line wrap: on
line source
/* * /gsm/rf/afcdac and /gsm/rf/stdmap each store a single 16-bit value, * and are not tables in the rftw/rftr sense, hence the code in rftablewr.c * does not handle these two. However, in fc-cal2text we would like to * handle their conversion from binary to ASCII the same way as the bigger * tables, hence the two functions in this module. */ #include <sys/types.h> #include <stdio.h> #include <stdint.h> #include <endian.h> void write_afcdac_ascii(bin, outf) uint16_t *bin; FILE *outf; { int i; i = le16toh(*bin); if (i >= 32768) i -= 65536; fprintf(outf, "%d\n", i); } void write_stdmap_ascii(bin, outf) uint16_t *bin; FILE *outf; { int i; i = le16toh(*bin); fprintf(outf, "0x%04X\n", i); }