FreeCalypso > hg > freecalypso-tools
view libserial-linux/setbyname.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | fd7b447b99e3 |
children |
line wrap: on
line source
/* * This module contains the wrapper function (used by loadtools) * that looks up a baud rate by name and calls set_serial_baud(). */ #include <stdio.h> #include <stdlib.h> #include "baudrate.h" extern struct baudrate *find_baudrate_by_name(); set_fixed_baudrate(baudname) char *baudname; { struct baudrate *br; br = find_baudrate_by_name(baudname); if (!br) exit(1); /* error msg already printed */ set_serial_baudrate(br); }