view loadtools/clmain.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents ecea01f65146
children
line wrap: on
line source

/*
 * This module contains the main() function for the XRAM chain-loading
 * utility fc-xram.
 */

#include <sys/types.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include "../libserial/baudrate.h"
#include "srecreader.h"

char *target_ttydev;

extern struct srecreader iramimage;
extern char default_loadagent_image[];
extern struct srecreader xramimage;
extern char hw_init_script[];
extern struct baudrate baud_rate_table[];
extern struct baudrate *current_baud_rate;

extern struct baudrate *find_baudrate_by_name();

struct baudrate *xram_load_baudrate;
struct baudrate *xram_run_baudrate = baud_rate_table;	/* 1st entry default */
int xram_jtag_mode;

char **passon_argv;
int passon_argc;

main(argc, argv)
	char **argv;
{
	extern char *optarg;
	extern int optind;
	int c;
	struct baudrate *br;

	while ((c = getopt(argc, argv, "+a:b:B:c:C:h:H:i:jP:r:t:")) != EOF)
		switch (c) {
		case 'a':
			iramimage.filename = optarg;
			continue;
		case 'b':
			set_romload_baudrate(optarg);
			continue;
		case 'B':
			br = find_baudrate_by_name(optarg);
			if (!br)
				exit(1);	/* error msg already printed */
			xram_load_baudrate = br;
			continue;
		case 'c':
			set_compalstage_short(optarg);
			continue;
		case 'C':
			set_compalstage_fullpath(optarg);
			continue;
		case 'h':
			read_hwparam_file_shortname(optarg);
			continue;
		case 'H':
			read_hwparam_file_fullpath(optarg);
			continue;
		case 'i':
			set_beacon_interval(optarg);
			continue;
		case 'j':
			xram_jtag_mode = 1;
			continue;
		case 'P':
			if (find_bootctrl_entry(optarg) < 0)
				exit(1);	/* error msg already printed */
			continue;
		case 'r':
			br = find_baudrate_by_name(optarg);
			if (!br)
				exit(1);	/* error msg already printed */
			xram_run_baudrate = br;
			continue;
		case 't':
			set_romload_timeout(optarg);
			continue;
		case '?':
		default:
usage:			fprintf(stderr,
		"usage: fc-xram [options] ttyport xramimage.srec [2ndprog]\n");
			exit(1);
		}
	if (argc - optind < 2)
		goto usage;
	target_ttydev = argv[optind];
	xramimage.filename = argv[optind+1];
	if (!iramimage.filename)
		iramimage.filename = default_loadagent_image;
	if (argc - optind >= 3) {
		passon_argv = argv + optind + 2;
		passon_argc = argc - optind - 2;
	}

	open_serial_port(target_ttydev);
	pwon_if_needed();
	perform_compal_stage();
	perform_romload();
	/* loadagent should be running now */
	if (tpinterf_pass_output(1) < 0)
		exit(1);
	if (hw_init_script[0]) {
		printf("Executing init script %s\n", hw_init_script);
		c = exec_init_script(hw_init_script);
		if (c)
			exit(1);
	}
	if (xram_load_baudrate && xram_load_baudrate != current_baud_rate) {
		c = loadagent_switch_baud(xram_load_baudrate);
		if (c)
			exit(1);
	}
	printf("Sending XRAM image to loadagent\n");
	perform_chain_load();
	if (passon_argv)
		exec_2nd_prog();
	tty_passthru();
	exit(0);
}