FreeCalypso > hg > freecalypso-tools
view loadtools/compalram.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 8c011177adb9 |
children |
line wrap: on
line source
/* * This module contains the main() function for fc-compalram, a trivial * utility that feeds a binary download image to Compal's bootloader * and then switches into serial tty pass-through. */ #include <stdio.h> #include <stdlib.h> char *target_ttydev; main(argc, argv) char **argv; { if (argc != 3) { fprintf(stderr, "usage: fc-compalram ttyport image.bin\n"); exit(1); } target_ttydev = argv[1]; set_compalstage_fullpath(argv[2]); open_serial_port(target_ttydev); perform_compal_stage(); tty_passthru(); exit(0); }