FreeCalypso > hg > freecalypso-tools
view loadtools/flashstubs.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 0dd2c87c1b63 |
children |
line wrap: on
line source
/* * The flash settings in the hardware parameter files specified with * -h or -H are meaningful only for fc-loadtool, but the same hwparam.c * code is included in fc-iram, fc-xram and fc-buzplay as well. * This module provides the stubs, allowing the other tools to link. */ void set_flash_config() { } void set_boot_reflash_hack() { }