FreeCalypso > hg > freecalypso-tools
view loadtools/labaud.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 8c011177adb9 |
children |
line wrap: on
line source
/* * This module handles the switching of serial baud rates * in coordination with loadagent. */ #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include "../libserial/baudrate.h" extern int target_fd; extern struct baudrate *current_baud_rate; extern struct baudrate *find_baudrate_by_name(); loadagent_switch_baud(newbr) struct baudrate *newbr; { char *argv[3]; static char U = 'U'; printf("Switching loadagent communication to %s baud\n", newbr->name); argv[0] = "baud"; argv[1] = newbr->name; argv[2] = 0; tpinterf_make_cmd(argv); if (tpinterf_send_cmd() < 0) return(-1); set_serial_baudrate(newbr); usleep(150000); write(target_fd, &U, 1); return tpinterf_pass_output(1); } cmd_baud(argc, argv) char **argv; { struct baudrate *br; if (argc < 2) { printf("Current baud rate is %s\n", current_baud_rate->name); return(0); } br = find_baudrate_by_name(argv[1]); if (!br) return(-1); /* error msg already printed */ return loadagent_switch_baud(br); }