FreeCalypso > hg > freecalypso-tools
view loadtools/lthelp.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 464a531122ab |
children |
line wrap: on
line source
/* * This module implements the loadtool help facility. */ #include <stdio.h> #include <ctype.h> #include <string.h> #include <strings.h> #include <stdlib.h> char loadtool_help_file[] = "/opt/freecalypso/helpfiles/loadtool.help"; loadtool_help(topic) char *topic; { FILE *f; char linebuf[256]; char *cp, *np; int flag; f = fopen(loadtool_help_file, "r"); if (!f) { perror(loadtool_help_file); return(-1); } for (;;) { if (!fgets(linebuf, sizeof linebuf, f)) { fprintf(stderr, "Help topic \"%s\" not found\n", topic); fclose(f); return(-1); } if (linebuf[0] != '=' || linebuf[1] != '=' || linebuf[2] != '=') continue; for (cp = linebuf + 3; isspace(*cp); cp++) ; for (np = cp; *cp && !isspace(*cp); cp++) ; if (*cp) *cp++ = '\0'; if (!strcmp(np, topic)) break; } for (flag = 0; fgets(linebuf, sizeof linebuf, f); ) { if (linebuf[0] == '=' && linebuf[1] == '=' && linebuf[2] == '=') { if (flag) break; else continue; } fputs(linebuf, stdout); flag = 1; } fclose(f); return(0); } cmd_help(argc, argv) char **argv; { char flashtopic[32]; switch (argc) { case 1: return loadtool_help("main"); case 2: return loadtool_help(argv[1]); case 3: if ((!strcmp(argv[1], "flash") || !strcmp(argv[1], "flash2")) && strlen(argv[2]) <= 20) { sprintf(flashtopic, "flash:%s", argv[2]); return loadtool_help(flashtopic); } fprintf(stderr, "No such help topic\n"); return(-1); default: fprintf(stderr, "internal error in cmd_help(): bad argc\n"); abort(); } }