FreeCalypso > hg > freecalypso-tools
view loadtools/scripts/compal.init @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | b0f9d38bfd9e |
children |
line wrap: on
line source
# Set WS=3 for both nCS0 and nCS1. This configuration is used by all official # C11x, C139/140 and SE J100 firmwares that have been examined, i.e., by the # official firmwares for all Compal models to which this init script applies. w16 fffffb00 00A3 w16 fffffb02 00A3 # Set the debug visibility bit in the FFFF:FB0E register so we can use # the flash mapping at 0x03000000 like on all other platforms. w16 fffffb0e 006A