FreeCalypso > hg > freecalypso-tools
view loadtools/scripts/cs2-4ws-8mb.init @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
# This loadtool init script provides memory interface register setup # for targets which fit the following criteria: # # 3 chip selects are used: nCS0, nCS1 and nCS2 # 4 wait states are to be used (register setting 00A4) # 8 MiB memory banks are in use, such that ADD22 needs to be enabled w16 fffffb00 00A4 w16 fffffb02 00A4 w16 fffffb04 00A4 w16 fffef006 0008