FreeCalypso > hg > freecalypso-tools
view loadtools/secondprog.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 064d4eedb3a6 |
children |
line wrap: on
line source
/* * This module contains the code for passing the serial channel to a * second program, used by fc-iram and fc-xram. */ #include <stdio.h> #include <stdlib.h> #include <unistd.h> extern char **passon_argv; extern int passon_argc; exec_2nd_prog() { char **execp_argv; char **sp, **dp; extern int target_fd; char desc_arg[16]; sprintf(desc_arg, "-d%d", target_fd); execp_argv = (char **) malloc(sizeof(char *) * (passon_argc + 2)); if (!execp_argv) { perror("malloc argv for execvp"); exit(1); } sp = passon_argv; dp = execp_argv; *dp++ = *sp++; *dp++ = desc_arg; while (*sp) *dp++ = *sp++; *dp = NULL; execvp(execp_argv[0], execp_argv); fprintf(stderr, "Unable to execvp %s\n", passon_argv[0]); exit(1); }