FreeCalypso > hg > freecalypso-tools
view loadtools/sertool.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 9ecbf1bf2e1b |
children |
line wrap: on
line source
/* * This module contains the main() function for fc-iram, previously * called fc-sertool: the simplest of the FreeCalypso loading tools, * which sends the user-specified IRAM SREC image to the boot ROM * and then switches into serial tty pass-through. */ #include <sys/types.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include "srecreader.h" char *target_ttydev; extern struct srecreader iramimage; char **passon_argv; int passon_argc; main(argc, argv) char **argv; { extern char *optarg; extern int optind; int c; while ((c = getopt(argc, argv, "+b:c:C:h:H:i:P:t:")) != EOF) switch (c) { case 'b': set_romload_baudrate(optarg); continue; case 'c': set_compalstage_short(optarg); continue; case 'C': set_compalstage_fullpath(optarg); continue; case 'h': read_hwparam_file_shortname(optarg); continue; case 'H': read_hwparam_file_fullpath(optarg); continue; case 'i': set_beacon_interval(optarg); continue; case 'P': if (find_bootctrl_entry(optarg) < 0) exit(1); /* error msg already printed */ continue; case 't': set_romload_timeout(optarg); continue; case '?': default: usage: fprintf(stderr, "usage: fc-iram [options] ttyport iramimage.srec\n"); exit(1); } if (argc - optind < 2) goto usage; target_ttydev = argv[optind]; iramimage.filename = argv[optind+1]; if (argc - optind >= 3) { passon_argv = argv + optind + 2; passon_argc = argc - optind - 2; } open_serial_port(target_ttydev); pwon_if_needed(); perform_compal_stage(); perform_romload(); if (passon_argv) exec_2nd_prog(); tty_passthru(); exit(0); }