FreeCalypso > hg > freecalypso-tools
view miscutil/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 8ddb16a37273 |
children |
line wrap: on
line source
CC= gcc CFLAGS= -O2 PROGS= arfcn2ti fc-pulse-dtr fc-pulse-rts fc-rgbconv fc-serterm imei-luhn \ make-imeisv mokosrec2bin srec-regions ti2arfcn SCRIPTS=c139explore pirexplore INSTALL_PREFIX= /opt/freecalypso INSTBIN=${INSTALL_PREFIX}/bin all: ${PROGS} SERTERM_OBJS= fc-serterm.o ttypassthru.o ../libserial/libserial.a arfcn2ti: arfcn2ti.c ${CC} ${CFLAGS} -o $@ $@.c fc-pulse-dtr: fc-pulse-dtr.c ${CC} ${CFLAGS} -o $@ $@.c fc-pulse-rts: fc-pulse-rts.c ${CC} ${CFLAGS} -o $@ $@.c fc-rgbconv: fc-rgbconv.c ${CC} ${CFLAGS} -o $@ $@.c fc-serterm: ${SERTERM_OBJS} ${CC} ${CFLAGS} -o $@ ${SERTERM_OBJS} ttypassthru.o: ../loadtools/ttypassthru.c ${CC} ${CFLAGS} -c -o $@ $< imei-luhn: imei-luhn.c ${CC} ${CFLAGS} -o $@ $@.c make-imeisv: make-imeisv.c ${CC} ${CFLAGS} -o $@ $@.c mokosrec2bin: mokosrec2bin.c ${CC} ${CFLAGS} -o $@ $@.c srec-regions: srec-regions.c ${CC} ${CFLAGS} -o $@ $@.c ti2arfcn: ti2arfcn.c ${CC} ${CFLAGS} -o $@ $@.c install: mkdir -p ${INSTBIN} install -c ${PROGS} ${SCRIPTS} ${INSTBIN} clean: rm -f ${PROGS} *.o *errs *.out