FreeCalypso > hg > freecalypso-tools
view ringtools/examples/bugle.pwt @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 07105f244424 |
children |
line wrap: on
line source
# This PWT example is an attempt to turn the "bugle" melody from # mmiMelody_data.c (defunct C file in TI's BMI code) into an actually # playable PWT melody. The command_2 word is guessed to be the note # duration in ms, with the TDMA_12 length being a bogon. c5 64 17 rest 1 e5 64 9 rest 1 g4 64 9 rest 1 c5 64 17 rest 10 c5 64 9 rest 1 c5 64 9 rest 1 c5 64 9 rest 1 e5 64 9 rest 1 g4 64 9 rest 1 c5 64 26 rest 10 c5 64 17 rest 1 e5 64 9 rest 1 g4 64 9 rest 1 c5 64 17 rest 10 c5 64 9 rest 1 c5 64 13 rest 1 c5 64 4 rest 1 e5 64 9 rest 1 g4 64 9 rest 1 c5 64 26 rest 9