FreeCalypso > hg > freecalypso-tools
view ringtools/examples/ring.pwt @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | 74331b35b1da |
| children |
line wrap: on
line source
# The most basic ringtone included in TI's TCS211 delivery was apparently # intended to consist of alternating 800 Hz and 900 Hz tones, although # the actual output was a continuous 99 Hz tone as a result of interface # mismatch between the BZ_Tone() driver function and the tone generation # tables. # # In 2016 we made FC Magnetite emit actual 800 Hz and 900 Hz tones, # or rather the closest approximations to these two frequencies that # can be produced in BU mode - see ring.buz example. In 2021 we are # looking into the possibility of switching from BU mode to PWT mode; # the present melody file is a test of how the closest PWT counterpart # to 800/900 Hz would sound. g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12 g5 64 12 a5 64 12