FreeCalypso > hg > freecalypso-tools
view ringtools/examples/rising-chrom.pwt @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | c4dafcc61cf7 |
children |
line wrap: on
line source
# This melody file is intended to be a basic test for the PWT melody play # mechanism - it consists of all 48 notes of the chromatic scale supported # by Calypso PWT, in rising order, with each note playing for 12 TDMA frames # at maximum nominal volume of 64/64. f4 64 12 fs4 64 12 g4 64 12 gs4 64 12 a4 64 12 as4 64 12 b4 64 12 c5 64 12 cs5 64 12 d5 64 12 ds5 64 12 e5 64 12 f5 64 12 fs5 64 12 g5 64 12 gs5 64 12 a5 64 12 as5 64 12 b5 64 12 c6 64 12 cs6 64 12 d6 64 12 ds6 64 12 e6 64 12 f6 64 12 fs6 64 12 g6 64 12 gs6 64 12 a6 64 12 as6 64 12 b6 64 12 c7 64 12 cs7 64 12 d7 64 12 ds7 64 12 e7 64 12 f7 64 12 fs7 64 12 g7 64 12 gs7 64 12 a7 64 12 as7 64 12 b7 64 12 c8 64 12 cs8 64 12 d8 64 12 ds8 64 12 e8 64 12 # The purpose of the following line is to test the implementation # of 'rest' instruction rest 12