FreeCalypso > hg > freecalypso-tools
view ringtools/examples/white-keys.pwt @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 7e9bad4ae14b |
children |
line wrap: on
line source
# This PWT test melody is a subset of rising-chrom.pwt, # reduced to just "white key" notes. f4 64 12 g4 64 12 a4 64 12 b4 64 12 c5 64 12 d5 64 12 e5 64 12 f5 64 12 g5 64 12 a5 64 12 b5 64 12 c6 64 12 d6 64 12 e6 64 12 f6 64 12 g6 64 12 a6 64 12 b6 64 12 c7 64 12 d7 64 12 e7 64 12 f7 64 12 g7 64 12 a7 64 12 b7 64 12 c8 64 12 d8 64 12 e8 64 12