FreeCalypso > hg > freecalypso-tools
view rvinterf/asyncshell/battery.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | b55a81ce7497 |
children |
line wrap: on
line source
/* * Functions for sending MMI_BATTERY_IND primitives with simulated * battery actions. */ #include <sys/types.h> #include <stdio.h> #include <ctype.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "pktmux.h" #include "limits.h" #include "exitcodes.h" static u_char mmi_battery_ind_fixedpart[24] = { RVT_L23_HEADER, 0x97, 24, 0, 0, 0, 0, 0, 'P', 'C', 'O', ' ', 'M', 'M', 'I', ' ', 'M', 'M', 'I', ' ', 0x03, 0x4E, 0, 0 }; send_mmi_battery_ind(byte1, byte2) { u_char pkt[28]; bcopy(mmi_battery_ind_fixedpart, pkt, 24); pkt[24] = byte1; pkt[25] = byte2; /* 2 padding bytes */ pkt[26] = 0; pkt[27] = 0; send_pkt_to_target(pkt, 28); return(0); } cmd_batt_common(argc, argv) char **argv; { u_char bytes[2]; int i; char *endp; for (i = 0; i < 2; i++) { bytes[i] = strtoul(argv[i], &endp, 0); if (*endp) { printf("error: invalid batt argument\n"); return(ERROR_USAGE); } } return send_mmi_battery_ind(bytes[0], bytes[1]); } void cmd_batt_interactive(argstr) char *argstr; { char *argv[3]; int argc, rc; rc = parse_interactive_command_into_argv(argstr, argv, 2, 2, &argc); if (rc < 0) return; cmd_batt_common(argc, argv); } cmd_batt_oneshot(argc, argv) char **argv; { return cmd_batt_common(argc - 1, argv + 1); }