view rvinterf/asyncshell/oneshot.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents b55a81ce7497
children
line wrap: on
line source

/*
 * This module implements the one-shot command mode of fc-shell.
 */

#include <stdio.h>
#include <string.h>
#include <strings.h>
#include <stdlib.h>
#include "limits.h"
#include "exitcodes.h"

extern int cmd_batt_oneshot();
extern int cmd_key_oneshot();
extern int cmd_keydown_oneshot();
extern int cmd_keyup_oneshot();
extern int cmd_poweroff();
extern int cmd_send_oneshot();
extern int cmd_sp_oneshot();
extern int cmd_str_oneshot();
extern int cmd_tchdl_oneshot();
extern int cmd_tgtreset();
extern int cmd_unterm_oneshot();

static struct cmdtab {
	char *cmd;
	int minargs;
	int maxargs;
	int (*func)();
} cmdtab[] = {
	{"batt", 2, 2, cmd_batt_oneshot},
	{"key", 1, 1, cmd_key_oneshot},
	{"keydown", 1, 1, cmd_keydown_oneshot},
	{"keyup", 1, 1, cmd_keyup_oneshot},
	{"poweroff", 0, 0, cmd_poweroff},
	{"send", 1, MAX_PKT_TO_TARGET, cmd_send_oneshot},
	{"sp", 2, 2, cmd_sp_oneshot},
	{"str", 1, 1, cmd_str_oneshot},
	{"tch-dl", 1, 1, cmd_tchdl_oneshot},
	{"tgtreset", 0, 0, cmd_tgtreset},
	{"unterm", 1, 1, cmd_unterm_oneshot},
	{0, 0, 0, 0}
};

oneshot_command(argc, argv)
	char **argv;
{
	struct cmdtab *tp;

	if (!strncmp(argv[0], "AT", 2) || !strncmp(argv[0], "at", 2)) {
		if (argc != 1) {
			fprintf(stderr,
			"error: AT command must be a single argument\n");
			exit(ERROR_USAGE);
		}
		return oneshot_at_command(argv[0]);
	}
	for (tp = cmdtab; tp->cmd; tp++)
		if (!strcmp(tp->cmd, argv[0]))
			break;
	if (!tp->func) {
		fprintf(stderr,
			"error: \"%s\" is not a valid one-shot command\n",
			argv[0]);
		exit(ERROR_USAGE);
	}
	if (argc - 1 > tp->maxargs) {
		fprintf(stderr, "%s: too many arguments\n", tp->cmd);
		exit(ERROR_USAGE);
	}
	if (argc - 1 < tp->minargs) {
		fprintf(stderr, "%s: too few arguments\n", tp->cmd);
		exit(ERROR_USAGE);
	}
	return tp->func(argc, argv);
}