FreeCalypso > hg > freecalypso-tools
view rvinterf/asyncshell/parse.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * This module implements the parser helper function that allows * the same code to be reused between interactive and one-shot * versions of the same command. */ #include <stdio.h> #include <ctype.h> #include <string.h> #include <strings.h> #include <stdlib.h> parse_interactive_command_into_argv(argstr, argv, min_arg, max_arg, argcp) char *argstr, **argv; int min_arg, max_arg, *argcp; { char *cp, **ap; cp = argstr; for (ap = argv; ; ) { while (isspace(*cp)) cp++; if (!*cp || *cp == '#') break; if (ap - argv >= max_arg) { printf("error: too many arguments\n"); return(-1); } if (*cp == '"') { *ap++ = ++cp; while (*cp && *cp != '"') cp++; if (*cp != '"') { printf("error: unterminated quoted string\n"); return(-1); } *cp++ = '\0'; } else { *ap++ = cp; while (*cp && !isspace(*cp)) cp++; if (*cp) *cp++ = '\0'; } } if (ap - argv < min_arg) { printf("error: too few arguments\n"); return(-1); } *ap = 0; *argcp = ap - argv; return(0); }