FreeCalypso > hg > freecalypso-tools
view rvinterf/ctracedec/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 90d7c360a614 |
children |
line wrap: on
line source
CC= gcc CFLAGS= -O2 PROG= ctracedec OBJS= decode.o doprnt.o main.o processlog.o readtab.o INSTALL_PREFIX= /opt/freecalypso INSTBIN=${INSTALL_PREFIX}/bin all: ${PROG} ${PROG}: ${OBJS} ${CC} ${CFLAGS} -o $@ ${OBJS} install: ${PROG} mkdir -p ${INSTBIN} install -c ${PROG} ${INSTBIN} clean: rm -f *.o *.out *errs ${PROG}