FreeCalypso > hg > freecalypso-tools
view rvinterf/etmsync/fscmdtab.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | 37b38b1a1136 |
| children |
line wrap: on
line source
/* * fc-fsio command dispatch table */ #include "cmdtab.h" extern int cmd_cleandir(); extern int cmd_cpout(); extern int cmd_cpout_file(); extern int cmd_delete(); extern int cmd_dieid(); extern int cmd_exec(); extern int cmd_exit(); extern int cmd_fd(); extern int cmd_ffs2ver(); extern int cmd_format(); extern int cmd_fwrite(); extern int cmd_hd(); extern int cmd_help(); extern int cmd_ll(); extern int cmd_ls(); extern int cmd_memdump(); extern int cmd_mkdir(); extern int cmd_omemdump(); extern int cmd_preformat(); extern int cmd_readlink(); extern int cmd_rm_subtree(); extern int cmd_set_imeisv(); extern int cmd_set_pcm_string(); extern int cmd_set_rfcap(); extern int cmd_stat(); extern int cmd_symlink(); extern int cmd_uploadfs(); extern int cmd_upload_file(); extern int cmd_upload_rf_table(); extern int cmd_upload_subtree(); extern int cmd_write_battery_table_v1(); extern int cmd_write_battery_table_v2(); extern int cmd_write_bsim_config(); extern int cmd_write_charging_config(); extern int create_std_dirs(); extern int get_pirelli_imei(); extern int pirelli_magnetite_init(); struct cmdtab cmdtab[] = { {"cleandir", 1, 1, cmd_cleandir}, {"cpout", 2, 2, cmd_cpout}, {"cpout-file", 2, 2, cmd_cpout_file}, {"create-std-dirs", 0, 0, create_std_dirs}, {"delete", 1, 1, cmd_delete}, {"dieid", 0, 0, cmd_dieid}, {"exec", 1, 1, cmd_exec}, {"exit", 0, 0, cmd_exit}, {"fd", 2, 3, cmd_fd}, {"ffs2ver", 0, 0, cmd_ffs2ver}, {"format", 1, 1, cmd_format}, {"fwrite", 3, 3, cmd_fwrite}, {"hd", 1, 1, cmd_hd}, {"help", 0, 1, cmd_help}, {"ll", 1, 1, cmd_ll}, {"ls", 1, 2, cmd_ls}, {"memdump", 2, 2, cmd_memdump}, {"mkdir", 1, 1, cmd_mkdir}, {"mk-std-dirs", 0, 0, create_std_dirs}, {"omemdump", 2, 2, cmd_omemdump}, {"pirelli-get-imei", 0, 0, get_pirelli_imei}, {"pirelli-magnetite-init", 0, 0, pirelli_magnetite_init}, {"preformat", 0, 0, cmd_preformat}, {"readlink", 1, 1, cmd_readlink}, {"rm", 1, 2, cmd_delete}, {"rm-subtree", 1, 2, cmd_rm_subtree}, {"set-imeisv", 2, 2, cmd_set_imeisv}, {"set-pcm-string", 2, 2, cmd_set_pcm_string}, {"set-rfcap", 1, 1, cmd_set_rfcap}, {"stat", 1, 1, cmd_stat}, {"symlink", 2, 2, cmd_symlink}, {"upload-file", 2, 2, cmd_upload_file}, {"upload-fs", 1, 1, cmd_uploadfs}, {"upload-rf-table", 1, 2, cmd_upload_rf_table}, {"upload-subtree", 2, 2, cmd_upload_subtree}, {"write-battery-table-v1", 1, 1, cmd_write_battery_table_v1}, {"write-battery-table-v2", 1, 1, cmd_write_battery_table_v2}, {"write-bsim-config", 2, 2, cmd_write_bsim_config}, {"write-charging-config", 1, 1, cmd_write_charging_config}, {0, 0, 0, 0} };