view rvinterf/etmsync/fsnew.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents 37b38b1a1136
children
line wrap: on
line source

/*
 * In this module we are going to implement the commands that upload
 * new FreeCalypso-invented stuff into the FFS of our FC devices.
 */

#include <sys/wait.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include "exitcodes.h"

char batterytab_compile_tool[]  = "/opt/freecalypso/bin/compile-fc-batt";
char batterytab2_compile_tool[] = "/opt/freecalypso/bin/compile-fc-batt2";
char charging_compile_tool[]    = "/opt/freecalypso/bin/compile-fc-chg";

upload_fc_table_from_ascii(asciisrc, compiletool, ffs_pathname)
	char *asciisrc, *compiletool, *ffs_pathname;
{
	char tmpfile[] = "/tmp/fc-fsioXXXXXX";
	int tmpfd;
	pid_t child, waitres;
	int status, rc;

	tmpfd = mkstemp(tmpfile);
	if (tmpfd < 0) {
		fprintf(stderr, "unable to get temp file via mkstemp()\n");
		return(ERROR_UNIX);
	}
	close(tmpfd);
	child = vfork();
	if (child < 0) {
		fprintf(stderr, "unable to vfork to run compiler tool\n");
		unlink(tmpfile);
		return(ERROR_UNIX);
	}
	if (!child) {
		execl(compiletool, compiletool, asciisrc, tmpfile, (char *) 0);
		perror(compiletool);
		_exit(ERROR_UNIX);
	}
	waitres = waitpid(child, &status, 0);
	if (waitres != child || !WIFEXITED(status)) {
		fprintf(stderr, "unexpected wait result after compiler run\n");
		unlink(tmpfile);
		return(ERROR_UNIX);
	}
	rc = WEXITSTATUS(status);
	if (rc) {
		unlink(tmpfile);
		return rc;
	}
	rc = fwrite_from_file(ffs_pathname, tmpfile);
	unlink(tmpfile);
	return rc;
}

cmd_write_battery_table_v1(argc, argv)
	char **argv;
{
	return upload_fc_table_from_ascii(argv[1], batterytab_compile_tool,
					  "/etc/batterytab");
}

cmd_write_battery_table_v2(argc, argv)
	char **argv;
{
	return upload_fc_table_from_ascii(argv[1], batterytab2_compile_tool,
					  "/etc/batterytab2");
}

cmd_write_charging_config(argc, argv)
	char **argv;
{
	return upload_fc_table_from_ascii(argv[1], charging_compile_tool,
					  "/etc/charging");
}

cmd_write_bsim_config(argc, argv)
	char **argv;
{
	static char filename[] = "/etc/batterysim";
	u_char bytes[4];

	bytes[0] = strtoul(argv[1], 0, 0);
	bytes[1] = strtoul(argv[2], 0, 0);
	bytes[2] = 0;	/* RFU */
	bytes[3] = 0;	/* RFU */
	return do_short_fwrite(filename, bytes, 4);
}