FreeCalypso > hg > freecalypso-tools
view rvinterf/etmsync/hostmkdir.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | d332fbf5c145 |
children |
line wrap: on
line source
/* * host_mkdir() function has been factored out into this module. */ #include <sys/types.h> #include <sys/stat.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include "exitcodes.h" host_mkdir(pathname) char *pathname; { int rc; struct stat st; rc = stat(pathname, &st); if (rc < 0) { rc = mkdir(pathname, 0777); if (rc < 0) { perror(pathname); return(ERROR_UNIX); } return(0); } else { if (S_ISDIR(st.st_mode)) return(0); else { fprintf(stderr, "error: %s already exists and is not a directory\n", pathname); return(ERROR_UNIX); } } }