view rvinterf/etmsync/l1tmops.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents 4694c7686ccd
children
line wrap: on
line source

/*
 * In this module we implement the functions that access the L1TM operations
 * which we are going to use in fc-tmsync and fc-readcal.
 */

#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>
#include "pktmux.h"
#include "tm3.h"
#include "l1tm.h"
#include "exitcodes.h"

extern u_char rvi_msg[];
extern int rvi_msg_len;

do_tms(arg)
{
	u_char cmdpkt[5];

	cmdpkt[1] = TM_MODE_SET;
	cmdpkt[2] = arg;
	cmdpkt[3] = arg >> 8;
	etm_pkt_exch(cmdpkt, 3);
	if (rvi_msg[3]) {
		fprintf(stderr, "target error %u in response to tms\n",
			rvi_msg[3]);
		return(ERROR_TARGET);
	}
	if (rvi_msg_len != 5) {
		fprintf(stderr, "target error: tms response wrong length\n");
		return(ERROR_TARGET);
	}
	return(0);
}

do_rfpr(index, retp)
	u_short *retp;
{
	u_char cmdpkt[5];

	cmdpkt[1] = RF_PARAM_READ;
	cmdpkt[2] = index;
	cmdpkt[3] = index >> 8;
	etm_pkt_exch(cmdpkt, 3);
	if (rvi_msg[3]) {
		fprintf(stderr, "target error %u in response to rfpr\n",
			rvi_msg[3]);
		return(ERROR_TARGET);
	}
	if (rvi_msg_len != 8) {
		fprintf(stderr, "target error: rfpr response wrong length\n");
		return(ERROR_TARGET);
	}
	if (rvi_msg[4] != index) {
		fprintf(stderr, "target error: rfpr response wrong index\n");
		return(ERROR_TARGET);
	}
	*retp = rvi_msg[5] | (rvi_msg[6] << 8);
	return(0);
}

do_rfpw(index, value)
{
	u_char cmdpkt[7];

	cmdpkt[1] = RF_PARAM_WRITE;
	cmdpkt[2] = index;
	cmdpkt[3] = index >> 8;
	cmdpkt[4] = value;
	cmdpkt[5] = value >> 8;
	etm_pkt_exch(cmdpkt, 5);
	if (rvi_msg[3]) {
		fprintf(stderr, "target error %u in response to rfpw\n",
			rvi_msg[3]);
		return(ERROR_TARGET);
	}
	if (rvi_msg_len != 6) {
		fprintf(stderr, "target error: rfpw response wrong length\n");
		return(ERROR_TARGET);
	}
	if (rvi_msg[4] != index) {
		fprintf(stderr, "target error: rfpw response wrong index\n");
		return(ERROR_TARGET);
	}
	return(0);
}

do_rftr(index, table, size)
	u_char *table;
{
	u_char cmdpkt[4];

	cmdpkt[1] = RF_TABLE_READ;
	cmdpkt[2] = index;
	etm_pkt_exch(cmdpkt, 2);
	if (rvi_msg[3]) {
		fprintf(stderr, "target error %u in response to rftr\n",
			rvi_msg[3]);
		return(ERROR_TARGET);
	}
	if (rvi_msg_len < size + 6) {
		fprintf(stderr, "target error: rftr response too short\n");
		return(ERROR_TARGET);
	}
	if (rvi_msg[4] != index) {
		fprintf(stderr, "target error: rftr response wrong index\n");
		return(ERROR_TARGET);
	}
	bcopy(rvi_msg + 5, table, size);
	return(0);
}

do_ttr(index, buf)
	u_char *buf;
{
	u_char cmdpkt[4];

	cmdpkt[1] = TX_TEMPLATE_READ;
	cmdpkt[2] = index;
	etm_pkt_exch(cmdpkt, 2);
	if (rvi_msg[3]) {
		fprintf(stderr, "target error %u in response to ttr\n",
			rvi_msg[3]);
		return(ERROR_TARGET);
	}
	if (rvi_msg_len != 38) {
		fprintf(stderr, "target error: ttr response wrong length\n");
		return(ERROR_TARGET);
	}
	if (rvi_msg[4] != index) {
		fprintf(stderr, "target error: ttr response wrong index\n");
		return(ERROR_TARGET);
	}
	bcopy(rvi_msg + 5, buf, 32);
	return(0);
}

do_mpr(index, retp)
	u_short *retp;
{
	u_char cmdpkt[5];

	cmdpkt[1] = MISC_PARAM_READ;
	cmdpkt[2] = index;
	cmdpkt[3] = index >> 8;
	etm_pkt_exch(cmdpkt, 3);
	if (rvi_msg[3]) {
		fprintf(stderr, "target error %u in response to mpr\n",
			rvi_msg[3]);
		return(ERROR_TARGET);
	}
	if (rvi_msg_len < 8) {
		fprintf(stderr, "target error: mpr response too short\n");
		return(ERROR_TARGET);
	}
	if (rvi_msg[4] != index) {
		fprintf(stderr, "target error: mpr response wrong index\n");
		return(ERROR_TARGET);
	}
	*retp = rvi_msg[5] | (rvi_msg[6] << 8);
	return(0);
}