FreeCalypso > hg > freecalypso-tools
view rvinterf/etmsync/piradccal.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 886f65760d09 |
children |
line wrap: on
line source
/* * This module is linked into fc-tmsync and implements a command for * retrieving Pirelli's VBAT ADC calibration. */ #include <sys/types.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include "localtypes.h" #include "exitcodes.h" get_pirelli_vbat_cal() { u_char bytes[2]; int a, b; int rc; rc = do_memory_read(0x027F06E5, bytes, 2); if (rc) return(rc); a = bytes[0] | (bytes[1] << 8); rc = do_memory_read(0x027F06F7, bytes, 2); if (rc) return(rc); b = bytes[0] | (bytes[1] << 8); if (b >= 32768) b -= 65536; printf("A=%d B=%d\n", a, b); return(0); }