FreeCalypso > hg > freecalypso-tools
view rvinterf/etmsync/tmscmdtab.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | aec320fe2653 |
| children |
line wrap: on
line source
/* * fc-tmsync command dispatch table */ #include "cmdtab.h" extern int cmd_aur(); extern int cmd_aur_all(); extern int cmd_dieid(); extern int cmd_exec(); extern int cmd_exit(); extern int cmd_madc(); extern int cmd_memdump(); extern int cmd_mpr(); extern int cmd_omemdump(); extern int cmd_rfpr(); extern int cmd_rfpw(); extern int cmd_rftr(); extern int cmd_tms(); extern int cmd_ttr(); extern int cmd_ttr_all(); extern int get_pirelli_vbat_cal(); extern int get_pirelli_imei(); struct cmdtab cmdtab[] = { {"aur", 1, 1, cmd_aur}, {"aur-all", 0, 0, cmd_aur_all}, {"dieid", 0, 0, cmd_dieid}, {"exec", 1, 1, cmd_exec}, {"exit", 0, 0, cmd_exit}, {"madc", 0, 0, cmd_madc}, {"memdump", 2, 2, cmd_memdump}, {"mpr", 1, 1, cmd_mpr}, {"omemdump", 2, 2, cmd_omemdump}, {"pirelli-get-imei", 0, 0, get_pirelli_imei}, {"pirelli-vbat-cal", 0, 0, get_pirelli_vbat_cal}, {"rfpr", 1, 1, cmd_rfpr}, {"rfpw", 2, 3, cmd_rfpw}, {"rftr", 1, 2, cmd_rftr}, {"tms", 1, 1, cmd_tms}, {"ttr", 1, 1, cmd_ttr}, {"ttr-all", 1, 1, cmd_ttr_all}, {0, 0, 0, 0} };