FreeCalypso > hg > freecalypso-tools
view rvinterf/include/bsim_etm_cmd.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | bc1e150f5bd9 |
children |
line wrap: on
line source
/* * This header file defines ETM commands that can be sent from a * development host to FCHG operating in BSIM mode. */ #ifndef __BSIM_ETM_CMD_H #define __BSIM_ETM_CMD_H /* ETM_BSIM command opcodes */ #define BSIM_CMD_QUERY 0x00 #define BSIM_CMD_DISCHARGE 0x01 /* 1 byte with battery % follows */ #define BSIM_CMD_CHG_START 0x02 #define BSIM_CMD_CHG_CI2CV 0x03 #define BSIM_CMD_CHG_COMPLETE 0x04 #define BSIM_CMD_SET_ICHG 0x05 /* 2 bytes of Ichg value follow */ #define BSIM_CMD_START_ENABLE 0x06 /* 1 byte with flag follows */ /* status response codes */ #define BSIM_STAT_OK 0x00 #define BSIM_ERR_BAD_CMD 0x02 #define BSIM_ERR_WRONG_STATE 0x03 #define BSIM_ERR_INV_PERCENT 0x04 #define BSIM_ERR_INV_DISCHARGE 0x05 #endif /* include guard */