FreeCalypso > hg > freecalypso-tools
view rvinterf/include/pktmux.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * Definitions for the RVT MUX over-the-wire protocol */ #define STX 0x02 #define DLE 0x10 #define RVT_RV_HEADER 0x11 #define RVT_L1_HEADER 0x12 #define RVT_L23_HEADER 0x13 #define RVT_TM_HEADER 0x14 #define RVT_RNET_HEADER 0x15 #define RVT_PROF_HEADER 0x16 #define RVT_GTTBACK_HEADER 0x17 #define RVT_OTHER_HEADER 0x18 /* FreeCalypso additions */ #define RVT_AT_HEADER 0x1A #define RVT_EXTUI_HEADER 0x1B #define RVT_TCH_HEADER 0x1C #define RVT_KEEPALIVE_HEADER 0x1D