FreeCalypso > hg > freecalypso-tools
view rvinterf/include/tmffs1.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/****************************************************************************** * FFS1 Protocol Indentifiers ******************************************************************************/ enum FFS1_PROTOCOL_IDENTIFIERS { FPI_END = 0, /* end */ FPI_BEGIN, /* begin */ FPI_TMFFS_VERSION, /* tmffs_version */ FPI_PREFORMAT, /* preformat */ FPI_FORMAT, /* format */ FPI_FCREATE, /* fcreate */ FPI_FUPDATE, /* fupdate */ FPI_FWRITE, /* fwrite */ FPI_FREAD, /* fread */ FPI_REMOVE, /* remove */ FPI_MKDIR, /* mkdir */ FPI_OPENDIR, /* opendir */ FPI_READDIR, /* readdir */ FPI_STAT, /* stat */ FPI_LINKSTAT, /* linkstat */ FPI_SYMLINK, /* symlink */ FPI_READLINK, /* readlink */ FPI_QUERY, /* query */ FPI_FCONTROL, /* fcontrol */ FPI_INIT, /* init */ FPI_EXIT, /* exit */ FPI_PCM_GETFILEINFO, /* getfileinfo */ FPI_PCM_READFILE, /* readfile */ FPI_PCM_WRITEFILE, /* writefile */ FPI_PCM_READRECORD, /* readrecord */ FPI_PCM_WRITERECORD, /* writerecord */ FPI_BUFREAD, /* buf_read */ FPI_BUFWRITE, /* buf_write */ FPI_BUFSET, /* buf_set */ FPI_UINT8, /* UINT8 */ FPI_UINT16, /* UINT16 */ FPI_UINT32, /* UINT32 */ FPI_INT8, /* INT8 */ FPI_INT16, /* INT16 */ FPI_INT32, /* INT32 */ FPI_BUFFER, /* BUFFER */ FPI_DATA, /* DATA */ FPI_STRBUF, /* STRBUF */ FPI_STRING, /* STRING */ FPI_TFFS /* TFFS */ };