FreeCalypso > hg > freecalypso-tools
view rvinterf/include/tmffs2.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | e7502631a0f9 |
| children |
line wrap: on
line source
/****************************************************************************** * FFS2 Protocol Indentifiers ******************************************************************************/ enum FFS2_PROTOCOL_IDENTIFIERS { TMFFS_FORMAT = 'f', TMFFS_PREFORMAT = 'p', TMFFS_MKDIR = 'm', TMFFS_OPENDIR = 'o', TMFFS_READDIR = 'D', TMFFS_REMOVE = 'd', TMFFS_RENAME = 'n', TMFFS_XLSTAT = 'x', TMFFS_SYMLINK = 'y', TMFFS_READLINK = 'Y', TMFFS_OPEN = 'O', TMFFS_CLOSE = 'C', TMFFS_READ = 'R', TMFFS_WRITE = 'W', TMFFS_SEEK = 'S', TMFFS_FTRUNCATE = 'T', TMFFS_TRUNCATE = 't', TMFFS_FILE_READ = 'r', TMFFS_FILE_WRITE = 'w', TMFFS_FSTAT = 'F', TMFFS_LSTAT = 'l', TMFFS_STAT = 's', TMFFS_FCONTROL = 'c', TMFFS_QUERY = 'q', TMFFS_INIT = 'i', TMFFS_EXIT = 'e', // Special TMFFS_DIRXLSTAT = 'X', TMFFS_VERSION = 'v', TMFFS_TFFS = 'z' }; #define TMFFS_STRING_SIZE 127 /* includes the terminating NUL */ #define MAX_READ_DATA 254