view rvinterf/tmsh/bsimresp.c @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents 9706832b740b
children
line wrap: on
line source

/*
 * Handling of ETM_BSIM responses (FreeCalypso addition to fw)
 */

#include <sys/types.h>
#include <stdio.h>
#include "bsim_etm_cmd.h"

extern u_char rvi_msg[];
extern int rvi_msg_len;

static char *cmd_names[] = {
	"query", "disch", "start", "ci2cv", "complete", "ichg", "start-enable"
};

static void
handle_bsim_error()
{
	char *errstr;
	char msg[80];

	if (rvi_msg_len != 6) {
		print_etm_pkt_raw("ETM_BSIM long error packet");
		return;
	}
	switch (rvi_msg[3]) {
	case BSIM_ERR_BAD_CMD:
		errstr = "bad command opcode";
		break;
	case BSIM_ERR_WRONG_STATE:
		errstr = "wrong state";
		break;
	case BSIM_ERR_INV_PERCENT:
		errstr = "invalid percent";
		break;
	case BSIM_ERR_INV_DISCHARGE:
		errstr = "invalid discharge";
		break;
	default:
		errstr = "unknown";
	}
	sprintf(msg, "bsim %s error 0x%02X (%s)", cmd_names[rvi_msg[4]],
		rvi_msg[3], errstr);
	async_msg_output(msg);
}

void
handle_bsim_response()
{
	char msg[80];

	if (rvi_msg_len == 5 && rvi_msg[3] == 0x3C) {
		async_msg_output("bsim: ETM_NOSYS response");
		return;
	}
	if (rvi_msg_len < 6) {
		print_etm_pkt_raw("ETM_BSIM response too short");
		return;
	}
	if (rvi_msg[4] > BSIM_CMD_START_ENABLE) {
		print_etm_pkt_raw("ETM_BSIM unknown opcode");
		return;
	}
	if (rvi_msg[3]) {
		handle_bsim_error();
		return;
	}
	if (rvi_msg_len == 6) {
		sprintf(msg, "bsim %s OK", cmd_names[rvi_msg[4]]);
		async_msg_output(msg);
		return;
	}
	if (rvi_msg[4] == BSIM_CMD_QUERY && rvi_msg_len == 9) {
		sprintf(msg, "bsim: state=%u percent=%u start_enable=%u",
			rvi_msg[5], rvi_msg[6], rvi_msg[7]);
		async_msg_output(msg);
		return;
	}
	print_etm_pkt_raw("ETM_BSIM response wrong length");
}