FreeCalypso > hg > freecalypso-tools
view rvinterf/tmsh/init.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 2c6dca514a20 |
children |
line wrap: on
line source
/* * This module contains the initialization code for fc-tmsh. */ #include <sys/types.h> #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "pktmux.h" #include "localsock.h" init() { static u_char want_rvt_lost[9] = {CLI2RVI_WANT_RVTRACE, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00}; static u_char want_rvt_etm[9] = {CLI2RVI_WANT_RVTRACE, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x1E, 0x00, 0x04}; static u_char want_etm_mux[2] = {CLI2RVI_WANT_MUXPROTO, RVT_TM_HEADER}; localsock_prep_for_length_rx(); send_init_command(want_rvt_lost, 9); send_init_command(want_rvt_etm, 9); send_init_command(want_etm_mux, 2); }