FreeCalypso > hg > freecalypso-tools
view rvinterf/tmsh/omw.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | c81d0e9ac3b4 |
children |
line wrap: on
line source
/* * Old-style memory write command */ #include <sys/types.h> #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "pktmux.h" #include "limits.h" #include "localtypes.h" #include "tm3.h" #include "exitcodes.h" cmd_omw(argc, argv) char **argv; { u32 addr, v; u_char cmdpkt[MAX_PKT_TO_TARGET]; int di; char **ap; addr = strtoul(argv[1], 0, 16); cmdpkt[1] = MEM_WRITE; cmdpkt[2] = addr; cmdpkt[3] = addr >> 8; cmdpkt[4] = addr >> 16; cmdpkt[5] = addr >> 24; di = 6; for (ap = argv + 2; *ap; ap++) { v = strtoul(*ap, 0, 16); cmdpkt[di++] = v; } send_etm_cmd(cmdpkt, di - 1); return(0); }