FreeCalypso > hg > freecalypso-tools
view target-utils/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 31 Aug 2023 19:38:18 +0000 |
| parents | f18db0f00ad8 |
| children | 8aeb840bc25f |
line wrap: on
line source
INSTPROGS= buzplayer calversion compalstage c139explore dspdump \ flash-boot-wa loadagent lunadrv pirexplore simagent simtest ALLPROGS= ${INSTPROGS} c139-lldbg flash-boot-test helloapp tf-breakin LIBS= libbase libc libcommon libprintf libtiffs SUBDIR= ${ALLPROGS} ${LIBS} INSTALL_PREFIX= /opt/freecalypso default: ${INSTPROGS} all: ${ALLPROGS} buzplayer: libbase libc libcommon libprintf c139explore: libbase libc libcommon libprintf c139-lldbg: libbase libc libcommon libprintf calversion: libbase libc libcommon libprintf dspdump: libbase libc libcommon libprintf flash-boot-test: libbase libc libcommon libprintf helloapp: libbase libc libcommon libprintf loadagent: libbase libc libcommon libprintf lunadrv: libbase libc libcommon libprintf pirexplore: libbase libc libcommon libprintf libtiffs simagent: libbase libc libcommon libprintf simtest: libbase libc libcommon libprintf ${SUBDIR}: FRC cd $@; ${MAKE} ${MFLAGS} install: FRC for i in ${INSTPROGS}; do (cd $$i; ${MAKE} ${MFLAGS} \ INSTDIR=${INSTALL_PREFIX}/target-bin install); done clean: FRC rm -f a.out core errs for i in ${SUBDIR}; do \ if [ -d $$i ]; then \ (cd $$i; ${MAKE} ${MFLAGS} clean) \ fi \ done FRC: