FreeCalypso > hg > freecalypso-tools
view target-utils/compalstage/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 2c9ea966edb9 |
children |
line wrap: on
line source
CC= arm-elf-gcc OBJCOPY=arm-elf-objcopy TARGETS=compalstage-plain.bin compalstage-thumb.bin compalstage-1003.bin \ compalstage-1004.bin INSTDIR=/opt/freecalypso/target-bin all: ${TARGETS} .SUFFIXES: .o .bin .o.bin: ${OBJCOPY} -O binary $< $@ compalstage-1003.o: compalstage.S ${CC} -DPAD_TO_1003 -c -o $@ $< compalstage-1004.o: compalstage.S ${CC} -DPAD_TO_1003 -DMAGIC_1004 -c -o $@ $< compalstage-plain.o: compalstage.S ${CC} -c -o $@ $< compalstage-thumb.o: compalstage.S ${CC} -DTHUMB_ENTRY -c -o $@ $< install: mkdir -p ${INSTDIR} install -c -m 644 ${TARGETS} ${INSTDIR} clean: rm -f *.o *errs *core *.bin FRC: