FreeCalypso > hg > freecalypso-tools
view target-utils/libc/memcmp.S @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | a675cec34076 |
children |
line wrap: on
line source
.text .code 32 .globl bcmp .globl memcmp bcmp: memcmp: cmp r2, #0 beq zero_len_out mov r3, r0 1: ldrb r0, [r3], #1 ldrb r12, [r1], #1 subs r0, r0, r12 bxne lr subs r2, r2, #1 bne 1b bx lr zero_len_out: mov r0, #0 bx lr