FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 0da2cf5a999c |
children |
line wrap: on
line source
CC= arm-elf-gcc CFLAGS= -Os -fno-builtin CPPFLAGS=-I../include AR= arm-elf-ar RANLIB= arm-elf-ranlib OBJS= abbcmd.o buzzer.o cmdentry.o defgetchar.o dispatch.o hexarg.o \ hexstrings.o parseargs.o uartsel.o cmd_baud_switch.o cmd_crc32.o \ cmd_dieid.o cmd_jump.o cmd_r8.o cmd_r16.o cmd_r32.o cmd_w8.o cmd_w16.o \ cmd_w32.o cmd_memdump_human.o cmd_memdump_machine.o all: libcommon.a libcommon.a: ${OBJS} ${AR} cru $@ ${OBJS} ${RANLIB} $@ clean: rm -f *.[oa] *errs