FreeCalypso > hg > freecalypso-tools
view target-utils/libprintf/README @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
The present libprintf is a very light printf implementation that is well-suited for simple bare-metal programs like loadagent; in the present case it overrides the much heavier printf implementation in newlib. Programs like the present loadagent only need printf in order to scribble on the serial console port, and the most sensible implementation is to have the "character output" function from the guts of printf point directly to the physical UART output routine, or a trivial wrapper that turns \n into \r\n. In contrast, newlib's version would pull in the complete FILE table infrastructure and malloc etc - maybe OK for more complex embedded programs that use those facilities for other things under a bona fide RTOS, but it would be disgusting to pull that stuff in for a minimal program like ours. The present printf implementation has been used earlier by the same author (Michael Spacefalcon) in the StarMON family of PowerPC bootloaders, and in my MC68x302-based SDSL CPE devices (Hack-o-Rocket and OSDCU).