FreeCalypso > hg > freecalypso-tools
view target-utils/loadagent/cmd_blankchk.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 0da2cf5a999c |
children |
line wrap: on
line source
/* * Flash blank check command */ #include <sys/types.h> #include "types.h" void cmd_blankchk(argbulk) char *argbulk; { char *argv[3]; u_long start, length; u_long addr; int c; if (parse_args(argbulk, 2, 2, argv, 0) < 0) return; if (parse_hexarg(argv[0], 8, &start) < 0) { printf("ERROR: arg1 must be a valid 32-bit hex address\n"); return; } if (parse_hexarg(argv[1], 8, &length) < 0) { printf("ERROR: arg2 must be a valid 32-bit hex value (length)\n"); return; } for (addr = start; addr < start + length; addr++) { c = *(volatile u8 *)addr; if (c != 0xFF) { printf("Not blank: %02X at %08X\n", c, addr); return; } } printf("OK\n"); }