FreeCalypso > hg > freecalypso-tools
view target-utils/lunadrv/luna.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | db9a8e88e63f |
children |
line wrap: on
line source
/* * This header file provides definitions for the Luna LCD hardware interface. */ /* reset control */ #define CNTL_RST_REG (*(volatile u16 *)0xFFFFFD04) #define EXT_RESET 0x0004 /* the LCD is connected to Calypso nCS3, with A1 line as register select */ #define LCD_IR (*(volatile u16 *)0x02000000) #define LCD_DR (*(volatile u16 *)0x02000002) /* macro for writing first IR, then DR */ #define LCD_REG_WR(reg, data) {LCD_IR = (reg); LCD_DR = (data);} /* some init operations call for controlled delays */ #define DELAY_1MS 13000