FreeCalypso > hg > freecalypso-tools
view target-utils/lunadrv/main.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | db9a8e88e63f |
children |
line wrap: on
line source
#include "types.h" main() { uart_select_init(); printf("Luna LCD driver utility running\n"); print_boot_rom_info(); /* Calypso MEMIF setup */ *(volatile u16 *)0xfffffb00 = 0x00A4; *(volatile u16 *)0xfffffb02 = 0x00A4; *(volatile u16 *)0xfffffb04 = 0x00A4; *(volatile u16 *)0xfffffb06 = 0x02A5; *(volatile u16 *)0xfffef006 = 0x0008; /* GPIO setup for backlight control */ *(volatile u16 *)0xfffef00a = 0x01E0; *(volatile u16 *)0xfffe4802 = 0x0200; *(volatile u16 *)0xfffe4804 = 0xFDFF; for (;;) { putchar('='); if (command_entry()) command_dispatch(); } }