FreeCalypso > hg > freecalypso-tools
view target-utils/simagent/byterx.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | c136a1a2474b |
children |
line wrap: on
line source
#include <stdlib.h> #include "types.h" #include "simregs.h" #include "timeout.h" rx_sim_byte(count) unsigned count; { for (; count; count--) { if (!(SIMREGS.stat & SIM_STAT_FEMPTY)) return SIMREGS.drx; } return(-1); } rx_sim_byte_hl() { int rc; unsigned parcnt; for (parcnt = 0; parcnt < 3; parcnt++) { rc = rx_sim_byte(SIM_WAIT_TIMEOUT); if (rc < 0) { printf("ERROR: timeout waiting for SIM response\n"); return(-1); } if (rc & 0x100) return rc & 0xFF; } printf("ERROR: received bad parity 3 times in a row\n"); return(-1); } flush_rx_fifo() { unsigned count; for (count = 0; ; ) { if (SIMREGS.stat & SIM_STAT_FEMPTY) break; (void) SIMREGS.drx; if (++count >= 32) { printf("ERROR: Rx FIFO flush does not end\n"); return(-1); } } return(0); } void cmd_sertimeout(argbulk) char *argbulk; { char *argv[2]; int count; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; count = atoi(argv[0]); rx_sim_byte(count); }