FreeCalypso > hg > freecalypso-tools
view target-utils/simagent/spenh.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | b761029f9c03 |
children |
line wrap: on
line source
#include <sys/types.h> #include <strings.h> #include "types.h" #include "simregs.h" extern int sim_if_state; extern u16 conf1_reg; const u8 pts_for_spenh[4] = {0xFF, 0x10, 0x94, 0x7B}; void cmd_spenh() { int rc; unsigned count; if (sim_if_state != 2) { printf("ERROR: SIM interface is not up\n"); return; } if (conf1_reg & SIM_CONF1_ETU) { printf("ERROR: speed enhancement is already on\n"); return; } rc = flush_rx_fifo(); if (rc < 0) return; rc = send_to_sim(pts_for_spenh, 4); if (rc < 0) return; for (count = 0; count < 4; count++) { rc = rx_sim_byte_hl(); if (rc < 0) return; if (rc != pts_for_spenh[count]) { printf("ERROR: PTS response does not match request\n"); return; } } SIMREGS.conf1 = conf1_reg |= SIM_CONF1_ETU; } void cmd_set_spenh(argbulk) char *argbulk; { char *argv[2]; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; if (!strcmp(argv[0], "0")) SIMREGS.conf1 = conf1_reg &= ~SIM_CONF1_ETU; else if (!strcmp(argv[0], "1")) SIMREGS.conf1 = conf1_reg |= SIM_CONF1_ETU; else printf("ERROR: \"0\" or \"1\" argument expected\n"); }