ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.

/*
 * This module contains the function that parses our hex string arguments.
 */

#include <ctype.h>
#include "types.h"

static
decode_hex_digit(c)
{
	if (isdigit(c))
		return c - '0';
	else if (islower(c))
		return c - 'a' + 10;
	else
		return c - 'A' + 10;
}

decode_hex_string_arg(arg, buf, maxlen)
	char *arg;
	u8 *buf;
	unsigned maxlen;
{
	unsigned count;

	for (count = 0; ; ) {
		while (isspace(*arg))
			arg++;
		if (!*arg)
			break;
		if (!isxdigit(arg[0]) || !isxdigit(arg[1])) {
			printf("ERROR: invalid hex string input\n");
			return(-1);
		}
		if (count >= maxlen) {
			printf("ERROR: hex string input is too long\n");
			return(-1);
		}
		buf[count++] = (decode_hex_digit(arg[0]) << 4) |
				decode_hex_digit(arg[1]);
		arg += 2;
	}
	return count;
}