FreeCalypso > hg > freecalypso-tools
view target-utils/simagent/timeout.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 2e16284d5029 |
children |
line wrap: on
line source
/* * This header file defines the loop-count timeout value that should * be passed to the rx_sim_byte() function. By the spec we have to wait * 9600 etu's; at 3.25 MHz SIM clock and the default slow mode (no speed * enhancement) this 9600 etu number translates to about 1.10 s. * * The constant defined here has been calibrated empirically; the measured * timeout is about 1.38 s, giving us reasonable safety margin. */ #define SIM_WAIT_TIMEOUT 6000000