FreeCalypso > hg > freecalypso-tools
view target-utils/simagent/tx.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 289733ff272b |
children |
line wrap: on
line source
/* * This module implements transmission of bytes toward the SIM. */ #include "types.h" #include "simregs.h" extern u16 conf1_reg; send_to_sim(bytes, count) u8 *bytes; unsigned count; { unsigned n, timeout, delay; if (conf1_reg & SIM_CONF1_ETU) delay = 6000; else delay = 30000; SIMREGS.conf1 = conf1_reg |= SIM_CONF1_TXRX; if (count == 1) wait_ARM_cycles(delay); (void) SIMREGS.it; for (n = 0; ; ) { SIMREGS.dtx = bytes[n++]; if (n == count) { SIMREGS.conf1 = conf1_reg &= ~SIM_CONF1_TXRX; return(0); } wait_ARM_cycles(delay); for (timeout = 12000; timeout; timeout--) if (SIMREGS.it & SIM_IT_ITTX) break; if (!timeout) { printf("ERROR: SIM interface Tx timeout on byte %u\n", n); return(-1); } } } void cmd_tx(argstr) char *argstr; { u8 bytes[5]; int rc; rc = decode_hex_string_arg(argstr, bytes, sizeof bytes); if (rc < 0) return; if (rc == 0) { printf("ERROR: empty hex string argument\n"); return; } send_to_sim(bytes, rc); }