FreeCalypso > hg > freecalypso-tools
view tchtools/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 94890123a74f |
children |
line wrap: on
line source
CC= gcc CFLAGS= -O2 PROGS= fc-efr2tch fc-fr2tch fc-gsm2vm fc-tch2fr fc-vm2gsmx fc-vm2hex INSTALL_PREFIX= /opt/freecalypso INSTBIN=${INSTALL_PREFIX}/bin all: ${PROGS} EFR2TCH_OBJS= fc-efr2tch.o efr2dsp.o FR2TCH_OBJS= fc-fr2tch.o gsm0610.o GSM2VM_OBJS= fc-gsm2vm.o gsm0610.o TCH2FR_OBJS= fc-tch2fr.o gsm0610.o VM2GSMX_OBJS= fc-vm2gsmx.o gsm0610.o fc-efr2tch: ${EFR2TCH_OBJS} ${CC} ${CFLAGS} -o $@ ${EFR2TCH_OBJS} fc-fr2tch: ${FR2TCH_OBJS} ${CC} ${CFLAGS} -o $@ ${FR2TCH_OBJS} fc-gsm2vm: ${GSM2VM_OBJS} ${CC} ${CFLAGS} -o $@ ${GSM2VM_OBJS} fc-tch2fr: ${TCH2FR_OBJS} ${CC} ${CFLAGS} -o $@ ${TCH2FR_OBJS} fc-vm2gsmx: ${VM2GSMX_OBJS} ${CC} ${CFLAGS} -o $@ ${VM2GSMX_OBJS} fc-vm2hex: fc-vm2hex.c ${CC} ${CFLAGS} -o $@ $@.c install: mkdir -p ${INSTBIN} install -c ${PROGS} ${INSTBIN} clean: rm -f ${PROGS} *.o *errs *.out