FreeCalypso > hg > freecalypso-tools
view tchtools/fc-gsm2vm.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 8ddb16a37273 |
children |
line wrap: on
line source
/* * This utility converts a GSM 06.10 speech recording from the format that is * commonly accepted as standard in the Unix/Linux world (libgsm format) into * a voice memo file that can be uploaded into the FFS of a FreeCalypso device * and played with the audio_vm_play_start() API or the AT@VMP command that * invokes the latter. */ #include <sys/types.h> #include <stdio.h> #include <stdlib.h> main(argc, argv) char **argv; { FILE *inf, *outf; u_char libgsm_bytes[33], tidsp_bytes[34], arm_bytes[34]; static u_char header_bytes[6] = {0x00, 0xC4, 0x00, 0x00, 0x00, 0x00}; static u_char endmarker[2] = {0xFF, 0xFB}; int cc, i, gotsome = 0; if (argc != 3) { fprintf(stderr, "usage: %s infile outfile\n", argv[0]); exit(1); } inf = fopen(argv[1], "r"); if (!inf) { perror(argv[1]); exit(1); } outf = fopen(argv[2], "w"); if (!outf) { perror(argv[2]); exit(1); } tidsp_bytes[33] = 0; for (;;) { cc = fread(libgsm_bytes, 1, 33, inf); if (cc < 33) break; if ((libgsm_bytes[0] & 0xF0) != 0xD0) { invalid: fprintf(stderr, "error: %s is not in libgsm format\n", argv[1]); exit(1); } gsm0610_libgsm_to_tidsp(libgsm_bytes, tidsp_bytes); for (i = 0; i < 34; i += 2) { arm_bytes[i] = tidsp_bytes[i+1]; arm_bytes[i+1] = tidsp_bytes[i]; } fwrite(header_bytes, 1, 6, outf); fwrite(arm_bytes, 1, 34, outf); gotsome = 1; } fwrite(endmarker, 1, 2, outf); fclose(outf); if (cc) { if (gotsome) fprintf(stderr, "warning: extra non-33 bytes at the end of %s\n", argv[1]); else goto invalid; } exit(0); }